Skip to content

Fix completion duplicate with xs:any #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2019
Merged

Fix completion duplicate with xs:any #563

merged 1 commit into from
Aug 23, 2019

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Aug 22, 2019 •
edited by fbricon
Loading

@angelozerr angelozerr mentioned this pull request Aug 22, 2019
Closed
@fbricon
Copy link
Contributor

fbricon commented Aug 22, 2019 •
edited
Loading

On completion, all tags already (edit: StackLayout ) in the document are missing the documentation part which points to their source (tns.xsd). All other tags have it

@fbricon
Copy link
Contributor

fbricon commented Aug 22, 2019

well actually no, this is not the proper cause, eg. DockLayout has no source tns.xsd and it's not already defined in the test-page.xml either

@fbricon
Copy link
Contributor

fbricon commented Aug 22, 2019

Seems to be concerning all *Layout tags. Probably a different bug then

@angelozerr
Copy link
Contributor Author

Seems to be concerning all *Layout tags. Probably a different bug then

I think it's because I provide local and global elements both. In DockLayout case, local element is added beforethe global element and it seems I cannot get the source in this case. To fix the problem completion provides only global elements.

@fbricon
Copy link
Contributor

fbricon commented Aug 23, 2019

so just add local elements after global ones?

@angelozerr
Fix completion duplicate with xs:any
5f15024 
See #177

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

so just add local elements after global ones?

I collect now local and global elements and fix bug with source. I have written test for that.

@fbricon fbricon merged commit 4eaea24 into master Aug 23, 2019
@angelozerr angelozerr deleted the xs-any-duplicate branch August 23, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelozerr @fbricon