-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Write Composite Operation #959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2021
This is probably not perfect but I think it's now in reviewable/testable state. The At client side :
|
This was referenced Jan 29, 2021
I changed the Map<String, Object> nodes = new HashMap<>();
nodes.put("/3/0/14", "+02");
nodes.put("/1/0/2", 100);
WriteCompositeResponse response = server.send(helper.getCurrentRegistration(),
new WriteCompositeRequest(ContentFormat.SENML_COBOR, nodes)); |
sbernard31
force-pushed
the
read_composite
branch
from
March 5, 2021 17:24
ae6cb69
to
3a184ab
Compare
sbernard31
force-pushed
the
write_composite
branch
from
March 5, 2021 17:24
5067781
to
6432a4b
Compare
Still not entirely satisfied by the API an maybe we should go to something like #981. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to add Write Composite support.
Atomicity at client side is not supported.
API at server side looks like :
This is not so good because resource Id is duplicate but for now I didn't find a better idea.
(This is a work in progress)