Prevent error on empty name symbol. #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: azerr <azerr@redhat.com>
|
@datho7561 if you have time, could you review this PR please. It is very annoying because if you write |
datho7561
approved these changes
Oct 8, 2024
|
Trying to see if the test failure is legitimate. |
|
It seems it's related to gradle on the microprofile.jdt side, which this PR doesn't change, so I think it's good to merge this PR. |
|
Thanks @datho7561 ! |
angelozerr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix : prevent from empty name symbol
Given this microprofile-config.properties file which have 2 dots in property:
a..b=vscode crashes because symbol name must be never empty.
This PR prevent from non empty name symbol.