-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config.getValue and ConfigValue.getValue #619
Comments
Well, we had that discussion about passing the type to provide conversion, but if I remember correctly, we decided to go simple with the API and add it later. If that changed, we can add it now. I'm not completely sure if Also, the idea is that we enhance |
@radcortez Thanks for the explaination! Maybe we should just change the method getValue to getStringValue() to reflect this purpose and later on we can make getValue to return something being converted. It is good to revisit and see whether it makes us confused. Thoughts? |
I guess it depends how you see it. Since the spec is all about Strings, and the original format is a String, I'm find with My idea was to add a |
The javadoc on Config.getValue() and ConfigValue.getVaue() are inconsistent.
config.getValue() https://github.com/eclipse/microprofile-config/blob/master/api/src/main/java/org/eclipse/microprofile/config/Config.java#L108
ConfigValue.getValue()
I think ConfigValue.getValue() should behave the same as Config.getValue(). The other thing is that ConfigValue.getValue() always return a string. Should we pass a calss type as the parameter and return the same type? If not, we should rename the method
getStringValue
instead.The text was updated successfully, but these errors were encountered: