-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigProviderTest TCK bug #664
Comments
Interesting, I wonder how the TCK passes here: https://github.com/smallrye/smallrye-config/runs/1477581698 |
Hmm I'm not sure either. I was guessing that the Microsoft Windows Server 2019 server which the GithHub Actions uses may have a "path" or "PATH" environment variable, but I can't tell for sure... |
@radcortez it depends on the Windows setting. Some Windows machine has PATH while others might have different variable name using different case. I think in the next release, we can improve the variable name mapping for env variable by ignoring the case as the fallback. |
I took a further look at this. Since the test in particular is to test the environment added, I think we can remove the line that causes the test unable to function in some OS. |
Describe the bug
microprofile-config/tck/src/main/java/org/eclipse/microprofile/config/tck/ConfigProviderTest.java
Lines 84 to 91 in 795080d
testEnvironmentConfigSource() searches for a Config Property called "path". However, on Windows machines the environment variable "path" doesn't exist. The variable is called "Path".
This causes the Assert to fail.
The text was updated successfully, but these errors were encountered: