Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Health Checks over MP Metrics & vice versa #267

Open
derekm opened this issue Jul 21, 2020 · 1 comment
Open

Expose Health Checks over MP Metrics & vice versa #267

derekm opened this issue Jul 21, 2020 · 1 comment

Comments

@derekm
Copy link
Contributor

derekm commented Jul 21, 2020

Exposing Health Checks over MP Metrics would provide recordation, audit & statistics as among the freebie use-cases that are met by such an integration.

On the flip side, deriving Health Checks from existing Metrics would also be beneficial.

Micrometer has a Service Level Objective API that allows building algebraic relationships between existing metrics in order to expose those metrics as new health indicators:

https://github.com/micrometer-metrics/micrometer/blob/master/implementations/micrometer-registry-health/src/main/java/io/micrometer/health/ServiceLevelObjective.java
https://github.com/micrometer-metrics/micrometer/blob/master/implementations/micrometer-registry-health/src/test/java/io/micrometer/health/HealthMeterRegistryTest.java
https://github.com/micrometer-metrics/micrometer/blob/master/implementations/micrometer-registry-health/src/test/java/io/micrometer/health/QueryTest.java

Micrometer's SLO API is fairly simple and straightforward, but one could also imagine using more sophisticated rules engines like clara-rules.org or kie.org in order to support rather sophisticated health indicator rules for observations made through the metrics system.

@xstefank
Copy link
Member

xstefank commented Feb 9, 2022

I like this idea but I would wait for the metrics specification with micrometer because we cannot depend on micrometer directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants