Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing 'express-rate-limit' in webui-docker image #966

Closed
HeikoBoettger opened this issue Jul 31, 2024 · 0 comments · Fixed by #971
Closed

missing 'express-rate-limit' in webui-docker image #966

HeikoBoettger opened this issue Jul 31, 2024 · 0 comments · Fixed by #971

Comments

@HeikoBoettger
Copy link

Seems like the following line is missing from the Dockerfile in webui:

RUN yarn add express-rate-limit@7.2.0

Overall I am a little bit surprised that not all dependencies listed in "dependencies" inside "package.json" are installed. Are they already provided by the base image?

The missing line causes:

node:internal/modules/cjs/loader:1147
  throw err;
  ^

Error: Cannot find module 'express-rate-limit'
Require stack:
- /home/node/webui/lib/default/server.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (/home/node/webui/lib/default/server.js:14:30)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/home/node/webui/lib/default/server.js' ]
}

Node.js v20.10.0

when running docker run -d ghcr.io/eclipse/openvsx-webui:v0.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant