Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of realloc #1484

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix usage of realloc #1484

wants to merge 1 commit into from

Conversation

haraldreif
Copy link

When realloc returns NULL, the memory of the argument ptr remains allocated. Thus overwriting the variable that holds this argument directly with the return value would lead to memory leaks as the allocated address is overwritten with NULL. To fix this, the return value is buffered and checked for NULL before overwriting the address variable.

Signed-off-by: Harald Reif haraldr@copadata.com

@haraldreif
Fix usage of realloc
a0d74eb 
When realloc returns `NULL`, the memory of the argument `ptr` remains allocated. Thus overwriting the variable that holds this argument directly with the return value would lead to memory leaks as the allocated address is overwritten with `NULL`. To fix this, the return value is buffered and checked for `NULL` before overwriting the address variable.

Signed-off-by: Harald Reif <haraldr@copadata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@haraldreif