This repository has been archived by the owner on May 7, 2020. It is now read-only.
Basic UI: several fix for selection and switch with mappings #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@resetnow : that is for you ;) |
| @@ -478,12 +479,11 @@ | |||
| item: _t.item, | |||
| value: value | |||
| })); | |||
| _t.suppressUpdate(); | |||
There was a problem hiding this comment.
[1] I understand that you need to obtain some properties from server so you don't want to suppress the callback entirely...
There was a problem hiding this comment.
[6] _t.suppressReset = true
| @@ -494,12 +494,16 @@ | |||
| _t.reset(); | |||
There was a problem hiding this comment.
[2] ...but could you please implement another way to suppress the useless call to reset()?
There was a problem hiding this comment.
[4]
if (_t.suppressReset) {
_t.suppressReset = false;
return;
} else {
_t.reset();
}
There was a problem hiding this comment.
[5] This has to do with animations and avoiding touching DOM too much
| @@ -455,7 +455,8 @@ | |||
| var | |||
| _t = this; | |||
|
|
|||
| _t.value = _t.parentNode.querySelector(o.formValue); | |||
| _t.hasValue = _t.parentNode.getAttribute("data-has-value") === "true"; | |||
| _t.value = _t.parentNode.parentNode.querySelector(o.formValue); | |||
| _t.count = _t.parentNode.getAttribute("data-count") * 1; | |||
There was a problem hiding this comment.
[3] For example, _t.suppressReset = false here.
|
@resetnow : thank you for your quick review, I fixed what you requested. |
vlad-ivanov-name
approved these changes
May 4, 2017
| _t.value.innerHTML = value; | ||
| } | ||
|
|
||
| if (_t.count === 1) { | ||
| return; | ||
| } | ||
|
|
||
| if (_t.suppressUpdateButtons ) { |
|
Space suppressed. |
|
Thanks! |
This was referenced May 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3143
Fix #3346
Fix #3349
Signed-off-by: Laurent Garnier lg.hc@free.fr