Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of ADAPT-VQE and Parameter Shift #201

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Implementation of ADAPT-VQE and Parameter Shift #201

merged 3 commits into from
Jun 12, 2020

Conversation

danclaudino
Copy link
Contributor

  • Implemented ADAPT-VQE
  • Implemented AlgorithmGradientStrategy class
  • Implemented Parameter Shift gradient
  • Fixed bugs in FermionOperator
  • Added commutator to Observable and derived classes
  • Added function to Optimizer.hpp to retrieve specified optimizer

Signed-off-by: Daniel Claudino 6d3@ornl.gov

@danclaudino
Implementation of ADAPT-VQE and Parameter Shift
395b339 
Signed-off-by: Daniel Claudino <6d3@ornl.gov>
@gitpod-io
Copy link

gitpod-io bot commented Jun 11, 2020 •
edited
Loading

amccaskey
amccaskey suggested changes Jun 11, 2020
View reviewed changes
xacc/optimizer/Optimizer.hpp Outdated Show resolved Hide resolved
quantum/observable/fermion/FermionOperator.cpp Show resolved Hide resolved
quantum/observable/fermion/FermionOperator.cpp Outdated Show resolved Hide resolved
quantum/observable/pauli/PauliOperator.cpp Outdated Show resolved Hide resolved
quantum/plugins/algorithms/adapt_vqe/adapt_vqe.cpp Show resolved Hide resolved
quantum/plugins/algorithms/adapt_vqe/adapt_vqe.cpp Outdated Show resolved Hide resolved
quantum/plugins/algorithms/adapt_vqe/adapt_vqe.cpp Outdated Show resolved Hide resolved
quantum/plugins/algorithms/adapt_vqe/adapt_vqe.cpp Outdated Show resolved Hide resolved
quantum/plugins/algorithms/adapt_vqe/tests/AdaptVQETester.cpp Outdated Show resolved Hide resolved
quantum/plugins/algorithms/adapt_vqe/tests/AdaptVQETester.cpp Show resolved Hide resolved
@danclaudino
Renamed variables, std::cout->xacc::info(), broke else ifs
2b073ad 
Signed-off-by: Daniel Claudino <6d3@ornl.gov>
@danclaudino
Print circuit and number of terms in commutator
159ce1f 
Signed-off-by: Daniel Claudino <6d3@ornl.gov>
@amccaskey
Copy link
Contributor

looks good, @danclaudino is covered under ut-battelle mla.

@amccaskey amccaskey merged commit c739e32 into eclipse-xacc:master Jun 12, 2020
danclaudino pushed a commit to danclaudino/xacc that referenced this pull request Sep 16, 2020
Merge pull request eclipse-xacc#201 from danclaudino/adapt-vqe-pr
59121cd 
Implementation of ADAPT-VQE and Parameter Shift
@danclaudino danclaudino deleted the adapt-vqe-pr branch December 19, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amccaskey amccaskey amccaskey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danclaudino @amccaskey