Skip to content

Check for cases where we a custom css is used instead of hidden element #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eneufeld opened this issue Mar 21, 2019 · 3 comments
Closed

Check for cases where we a custom css is used instead of hidden element #1307

eneufeld opened this issue Mar 21, 2019 · 3 comments
Assignees
@sdirix
Labels
material react
Milestone
2.2.3

Comments

@eneufeld
Copy link
Member

Describe the bug
In some renderers we used a custom CSS to hide the element instead of using the Hidden element of the MUI library. We should check for all those occurrences and replace them with the Hidden element.

Used Setup (please complete the following information):

  • Framework: [e.g. react, angular] react
  • RendererSet: [e.g. material, vanilla] material
@edgarmueller edgarmueller added this to the 2.2.3 milestone Mar 22, 2019
@edgarmueller
Copy link
Contributor

I think this is not the case anymore after #1304, at least not for the material-renderers package.

@edgarmueller
Copy link
Contributor

Well, it still is, occurrences include: MaterialLabelRenderer, NoBorderTableCell, MaterialInputControl and MaterialGroupLayout.

@sdirix sdirix mentioned this issue Apr 16, 2019
Merged
@edgarmueller
Copy link
Contributor

Fixed via #1330.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdirix sdirix

Labels
material react
Projects
None yet
Milestone
2.2.3
Development

No branches or pull requests
3 participants
@edgarmueller @eneufeld @sdirix