Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation Values #1930

Closed
sdirix opened this issue May 10, 2022 · 1 comment · Fixed by #1939
Closed

Translation Values #1930

sdirix opened this issue May 10, 2022 · 1 comment · Fixed by #1939
Assignees
@LukasBoll
Labels
core
Milestone
3.0

Comments

@sdirix
Copy link
Member

sdirix commented May 10, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

We should add more meta information for translations

Describe the solution you'd like

  • add locale to each call to the translation function Edit: Actually this is unnecessary. The users already know the locale as they hand it over to JSON Forms anyway.
  • add error or errors to each call of the translation function regarding errors

Describe alternatives you've considered

None

Framework

Core

RendererSet

Other (please specify in the Additional context field)

Additional context

No response
@sdirix sdirix added this to the 3.0 milestone May 13, 2022
@sdirix sdirix linked a pull request May 23, 2022 that will close this issue
add errors parameter to translation function #1939
Merged
@sdirix
Copy link
Member Author

sdirix commented May 23, 2022

Implemented with #1939

@sdirix sdirix closed this as completed May 23, 2022
@sdirix sdirix added the core label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasBoll LukasBoll

Labels
core
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

add errors parameter to translation function LukasBoll/jsonforms
2 participants
@sdirix @LukasBoll