Add WebView Support eclipsesource/theia-cloud#296 #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
hosts.paths.tlsSecretName
boolean property which defaults tofalse
(i.e. default behaviour is the same). When set totrue
the same secretName as for the subdomain based ingresses will be used then.ingress.certManagerAnnotations
. This is useful when the certifcates won't be managed by cert-manager at all. Default is stilltrue
.hosts.additionalWildcardInstances
to instances. This is required when the certificates shall be managed via cert-manager, so that all possible paths are already available in the ingress and therefore included in the requests of the cert-manager.Also see eclipse-theia/theia-cloud#298 (also contains testing instructions)
eclipse-theia/theia-cloud#296