Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up pre-commit to handle linting (also in cicd) #2

Open
leifdenby opened this issue Jan 26, 2024 · 2 comments
Open

Set up pre-commit to handle linting (also in cicd) #2

leifdenby opened this issue Jan 26, 2024 · 2 comments

Comments

@leifdenby
Copy link

I have a quick suggestion I would like to make which would be set up pre-commit to handle the linting. pre-commit is easy to run locally (it can be installed with a git hook to run on every commit), ties in easily with github actions and with the same configuration locally and on cicd it easier to ensure that code stays clean.

If this sounds good I am happy to add the configuration and set up the cicd part too 😄 I am primarily asking @b8raoult because I just noticed you did a commit for handling some linting fixes for black.

@JesperDramsch
Copy link
Contributor

Hi @leifdenby, thanks for the suggestion.

we had a pretty hefty pre-commit flying around that I worked on.
Happy if you want to add useful parts and if you have suggestions for the CI/CD, as I haven't set that up yet.

@leifdenby
Copy link
Author

Great, I'll make a pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants