-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ISO8601 for dates, datetimes and durations #3
Comments
As long as the behaviour is the same, no problem. |
It would change the functionality in how to provide dates, datetimes and duration. So it depends on what you mean by "behaviour". From the README on specifying date ranges it currently says:
I don't think it is a good idea to support so many variations on how to format dates. For example if someone set Also, having so many variations means that another application needs to implement a lot of logic to be able to support parsing of the config file. I can for example imagine wanting to use these values in javascript (a frontend the visualises data ranges used for a dataset). ISO8601 is supported in many different javascript libraries (for example momentjs) Finally, I think the current way the So what I suggest is that we depreciate the current format and only support strings formatted according to ISO8601. That will mean the README would instead read:
|
This will also change how frequencies should be given. In the ISO 8601 standard this are done with |
You are welcome to implement the changes. Just make sure that they are backwards compatible for now, so that our current software stack still works. It is just a matter of accepting both types of input. |
I would like to suggest that rather than using a customised data-related object serialisation
ecml-tools
adopts the ISO8601 standard. There is a really nice python package isodate for handling parsing of these and it makes it much easier to build other tools that can work with the same configuration files etc. Also, it avoids users having to try to understand a new format just to use the package.The text was updated successfully, but these errors were encountered: