Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprocessor tests do not cover inference mode #29

Open
4 tasks
sahahner opened this issue Dec 17, 2024 · 0 comments
Open
4 tasks

Preprocessor tests do not cover inference mode #29

sahahner opened this issue Dec 17, 2024 · 0 comments
Assignees
@sahahner
Labels
bug Something isn't working models

Comments

@sahahner
Copy link
Member

sahahner commented Dec 17, 2024 •
edited
Loading

What happened?

At the moment, the preprocessor tests only cover the training case.
For the inference case, the batches are of different shapes. This should be covered in the tests.

  • Multimapper
  • Monomapper
  • Normalizer
  • Imputer

What are the steps to reproduce the bug?

If the preprocessor transform or inverse_transform functions use incorrect data indices in the inference case, the tests do not fail.

Version

develop

Platform (OS and architecture)

atos

Relevant log output

No response

Accompanying data

No response

Organisation

No response
@sahahner sahahner added the bug Something isn't working label Dec 17, 2024
@sahahner sahahner self-assigned this Dec 17, 2024
@JesperDramsch JesperDramsch transferred this issue from ecmwf/anemoi-models Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahahner sahahner

Labels
bug Something isn't working models
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

29-preprocessor-tests-do-not-cover-inference-mode ecmwf/anemoi-core
2 participants
@JesperDramsch @sahahner