Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement plugins #217

Closed
sandorkertesz opened this issue Oct 6, 2023 · 1 comment · Fixed by #263
Closed

Implement plugins #217

sandorkertesz opened this issue Oct 6, 2023 · 1 comment · Fixed by #263
Assignees
@sandorkertesz
Labels
enhancement New feature or request

Comments

@sandorkertesz
Copy link
Collaborator

sandorkertesz commented Oct 6, 2023 •
edited
Loading

This should be done based on the climetlab implementation.
@sandorkertesz sandorkertesz added the enhancement New feature or request label Oct 6, 2023
@sandorkertesz sandorkertesz self-assigned this Oct 6, 2023
@sandorkertesz
Copy link
Collaborator Author

sandorkertesz commented Oct 16, 2023 •
edited
Loading

Some questions arise concerning the earthkit-data plugins:

  • do we want to support the dataset plugins? At the moment, datasets are not part of earthkit-data. They are loaded in climetlab with load_dataset(name, *args)
  • do we require the plugins to be namespace packages (within the earthkit namespace)?

Following an internal discussion we came to the following decisions:

  • datasets will not be implemented in earthkit-data
  • plugins need not to be namespace packages

@sandorkertesz sandorkertesz linked a pull request Nov 27, 2023 that will close this issue
Feature/plugins #263
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandorkertesz sandorkertesz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/plugins ecmwf/earthkit-data
1 participant
@sandorkertesz