-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding examples runs to the travis scripts #602
Comments
The currently pytest report I get on the HARK/examples/ notebooks https://gist.github.com/sbenthall/cf7e68ccd19b3989efa38a07f00cddf7 |
How much time did it take the run the suite? |
Quite some time. I didn't time it. The So we'll need to move it to REMARK to clear it out if we want to go down this road. That's ticketed at #531 |
Regarding how long it takes to run the notebook, my view is:
|
The notebook The presumption that these notebooks are interactive rubs up against the idea that these notebooks will be turned into static documentation rendered here: Indeed the later cells in this notebook are not being executed and rendered at the moment. This makes these notebooks less effective as documentation. I'll remove the presumed interactive and fully render the notebook in a PR. |
For my teaching purposes, I found it useful to split the "Gentle Intro" into two parts, one about the Perfect Foresight model and a second about the model with transitory and permanent income shocks. (The two notebooks are still in DemARK).
@mnwhite was the primary author of the Gentle Introduction and he might want to leave it as-is for his teaching purposes (when we taught a class together, he presented the whole thing as a standalone set-piece). But as-is it can't go in examples for the reason you note: It doesn't run unattended. Maybe we could move it to the TITLARK (Teaching and Instructional Tools for Learning the ARK) -- though my suspicion is that Matt hates the TITLARK and therefore would not like his Gentle Intro to live there. |
I don't presume anything regarding the pedagogical materials (DemARKs, QuARKs, TITLARKs, etc.) ... except that since they seem to be mainly about curriculum design, which is a complex and multifaceted problem with a lot of complexity, that they be decoupled from the development of HARK core so that the latter can adhere more closely to best practices in software engineering. |
That's a good dividing line. If making something comply is too much work, then the content should not be part of Econ/ARK, but can be private and USE HARK (like anyone else). |
Somebody (@MridulS ?) has implemented this as GitHub Actions. Closing ticket. |
It looks like several of the examples currently run with errors on
master
.These need to be fixed.
Once they are fixed, it would make sense to add the line to run then all (maybe just the notebooks) as part of travis.
The text was updated successfully, but these errors were encountered: