Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

existence of cstwMPCagent in TractableBufferStockModel #653

Closed
MridulS opened this issue Apr 23, 2020 · 3 comments
Closed

existence of cstwMPCagent in TractableBufferStockModel #653

MridulS opened this issue Apr 23, 2020 · 3 comments
Milestone

Comments

@MridulS
Copy link
Member

MridulS commented Apr 23, 2020

To run the "tractable" version of cstwMPC there is a commented line in TractableBufferStockModel which imports cstwMPCagent.

# If you want to run the "tractable" version of cstwMPC, uncomment the line below

Should we move this to somewhere in documentation of the cstwMPC REMARK, https://github.com/llorracc/cstwMPC ?

@llorracc
Copy link
Collaborator

If I understand what is going on there, this is not at all a good way to do it.

The functionality of interest was being able to solve the cstwMPC model using the simpler (and much, much faster) Tracable model, which is basically the "wrong" model but can quickly produce a good starting point for iteration toward the "right model". @mnwhite probably will be able to explain this better.

@sbenthall
Copy link
Contributor

see #669 #668

@sbenthall sbenthall added this to the 1.1.0 milestone Jan 29, 2021
@mnwhite
Copy link
Contributor

mnwhite commented Jul 3, 2024

This was cleaned up a while ago. There's now just a comment indicating how it would be done.

@mnwhite mnwhite closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants