Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user that tasks cannot be killed #674

Closed
jiho opened this issue May 10, 2021 · 2 comments
Closed

Inform user that tasks cannot be killed #674

jiho opened this issue May 10, 2021 · 2 comments
Assignees
Labels
tasks ui User interface aspect

Comments

@jiho
Copy link
Contributor

jiho commented May 10, 2021

With the new organisation of tasks (jobs) that run on the backend while being launched from the front end, it is difficult to kill a running task.
In addition, for data consistency purposes, killing as task that leads to writes in the DB (e.g. imports) should remove all those writes, leaving no trace that the task was even run, which is even harder.

Hence it is now impossible to kill tasks (jobs).

The user need to be informed. Next to the last button before running the task (import, export, etc.) add a note:

"Once a task is launched, for consistency and performance reasons, it cannot be killed. You must wait for it to finish. Please make sure that it you chose the correct options above."

@jiho jiho added tasks ui User interface aspect labels May 10, 2021
@moi90
Copy link

moi90 commented May 26, 2021

In addition, for data consistency purposes, killing as task that leads to writes in the DB (e.g. imports) should remove all those writes, leaving no trace that the task was even run, which is even harder.
Shouldn't an import be wrapped in a single DB transaction that is rolled back if an error occurs or if the task is killed?

@grololo06
Copy link
Member

Tasks can be killed by clicking the "Clean task data" button. The task will die next time it tries to access its private data, which is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks ui User interface aspect
Projects
None yet
Development

No branches or pull requests

3 participants