Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move acquisition.instrument DB column to a "free column" #786

Open
grololo06 opened this issue Mar 14, 2022 · 2 comments
Open

Move acquisition.instrument DB column to a "free column" #786

grololo06 opened this issue Mar 14, 2022 · 2 comments
Labels
feature New functionality

Comments

@grololo06
Copy link
Member

grololo06 commented Mar 14, 2022

Follow-up of #264.
For each project, add a free acquisition column in the acquisition-level mappings (column projects.mappingacq).
Copy acquisition.instrument existing data into this new free column.
Unfortunately, for existing production data, 2 lines have their "free columns" taken entirely, meaning we'd need to add a t31, to be sure to cover all cases.
The project-level mappings are plain text, meaning a specific parsing is needed to ensure correct compatibility with back-end. Python in PG?

@grololo06 grololo06 added the feature New functionality label Mar 14, 2022
@grololo06 grololo06 self-assigned this Mar 14, 2022
@grololo06
Copy link
Member Author

Corresponding mapping will also be to remove in import code.

@jiho
Copy link
Contributor

jiho commented Mar 17, 2022

Regarding this

Unfortunately, for existing production data, 2 lines have their "free columns" taken entirely, meaning we'd need to add a t31, to be sure to cover all cases.

The amount of free columns could also be increased to 60 in anticipation of merging acq and process. Also, 30 appeared to be limiting in some cases in the past.

@grololo06 grololo06 removed their assignment Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

No branches or pull requests

2 participants