Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Adjust brightness and contrast of images #861

Open
moi90 opened this issue Jan 25, 2024 · 7 comments
Open

Feature request: Adjust brightness and contrast of images #861

moi90 opened this issue Jan 25, 2024 · 7 comments

Comments

@moi90
Copy link

moi90 commented Jan 25, 2024

Sometimes, images are easier to annotate if their contrast is stretched (for example). However, this currently requires altering the image file.

I propose a small UI to change brightness and contrast of the displayed images. This can be purely done with JS and CSS:

https://www.w3schools.com/cssref/css3_pr_filter.php

If you point me in the right direction, I might start working on it.

@moi90
Copy link
Author

moi90 commented Jan 26, 2024

I created a fiddle to show the functionality:

https://jsfiddle.net/6qmpt40n/23/

grafik

As EcoTaxa already uses JQuery, it should be easy to include this.

@grololo06
Copy link
Member

grololo06 commented Feb 2, 2024

As all images in a page are likely to have the same need for improvement (and we have big CPUs nowadays), I think it would make sense to have this globally for all visible objects in a classification page, and with Brightness/Contrast controls always visible. Users won't bother clicking a button then adjusting then closing.

@moi90
Copy link
Author

moi90 commented Feb 2, 2024

I think it would make sense to have this globally for all visible objects in a classification page

Yes, exactly what I was thinking! (Not for each individual object, that would be stupid.)

with Brightness/Contrast controls always visible. Users won't bother clicking a button then adjusting then closing.

Is there enough space on the screen? It could also be a menu (that opens on hover) with the sliders. Or two simple dropdowns (analogous to, and next to, the magnification dropdown). The nice thing about the sliders is that the effect on the images is instant, while dragging.

@bea777515
Copy link
Collaborator

Closed -> moved on clickup - will be a feature of the new classification page (similar but tailwindcss - vanilla js) , interactions to be clarified

@moi90
Copy link
Author

moi90 commented Feb 23, 2024

Great that you will be working on it! Is the Clickup publicly viewable? (Otherwise, it might make sense to keep this issue open until the feature is actually implemented.)

@bea777515
Copy link
Collaborator

re-opened , ideas about the controls and interactions can be clarified here

@bea777515
Copy link
Collaborator

I am closing all the issues , and moving them to clickup , except those to be clarified , and, you are right, this one should stay here to add ideas about the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants