Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input components not syncing with reactive forms validation #155

Closed
trevordaniels opened this issue Jul 4, 2017 · 1 comment
Closed

Input components not syncing with reactive forms validation #155

trevordaniels opened this issue Jul 4, 2017 · 1 comment
Assignees
@edcarroll
Labels
comp: checkbox comp: datepicker comp: select priority: low type: feature
Milestone
0.9.2

Comments

@trevordaniels
Copy link
Contributor

sui-select and sui-checkbox dont seem to be in sync with angular validation classes when using reactive forms.

eg. After clicking on a Checkbox component, the sui-checkbox element does not update its class to ng-touched, whereas the inner input element does. Conversely, the outer element handles dirty/pristine and valid/invalid correctly whereas the inner element does not.

http://plnkr.co/edit/u8FrRU77lZ0l3Ss0BUeB
@edcarroll edcarroll mentioned this issue Jul 4, 2017
Merged
@edcarroll edcarroll self-assigned this Jul 4, 2017
@edcarroll edcarroll added this to the 0.9.2 milestone Jul 4, 2017
@edcarroll
Copy link
Owner

0.9.2 has just gone live, which adds full ng-touched support to the checkbox, select & datepicker components.

The checkbox specifically now only gains ng-touched when focus is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edcarroll edcarroll

Labels
comp: checkbox comp: datepicker comp: select priority: low type: feature
Projects
None yet
Milestone
0.9.2
Development

No branches or pull requests
2 participants
@trevordaniels @edcarroll