-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Directories reorder and renaming #4
Comments
@amitdo Hey, thanks! I left these folders with the same structure because I really only ported the old code written in 1996 by Stephen Rice to modern computers, and added UTF-8 support. The only thing I did in terms of structure is move everything from Why would you suggest these changes? |
Hi again! I reviewed your commits, so I know what changes you made so far.
Well, It's a matter of style. Many open source projects have a directory layout that include 'src' and/or 'lib' dirs. Some projects use 'prog(s)' dir, but it's less common. https://github.com/kriasoft/Folder-Structure-Conventions It's just a suggestion, feel free to not accept it... :) BTW, a few years ago I started rewriting this project in Python. Never finished it... |
FYI, I added a link to this project to Tesseract wiki: I hope this is ok with you. |
Heya! Sorry if I sounded offended in my last post; I have a conference submission deadline looming and a major assignment due soon, so adding more potential work for me right now is like 😫 That said! This is a good idea! 😄 However, I like a more unix-y structure a bit better:
This way, developers on Unix-y systems can simply add each directory to their respective paths: ISRI=$HOME/isri-ocr-evaluation-tools # or wherever you decide to put this repo
export PATH=$ISRI/bin:$PATH
export MANDIR=$ISRI/man:$MANPATH
export LD_LIBRARY_PATH=$ISRI/lib:$LD_LIBRARY_PATH I've suggested a public API, which may be a lot of work, but if implemented, you could link with ISRI libs like so: g++ \
-I$HOME/isri-ocr-evaluation-tools/include \ # Typically set in CPPFLAGS in a Makefile
-L$HOME/isri-ocr-evaluation-tools/lib \ # Typically set in LDFLAGS in a Makefile
mycoolocrthing.cc -o mycoolocrthing \
-lisri # Link with ISRI OCR evaluation tools Edit: And yeah, it's okay for this project to be listed on the Tesseract page! My colleagues wanted to evaluate their Tesseract-based OCR engine and they found the ISRI tool to be the best for it (being dissatisfied with more modern options like ocrevalUAtion). |
👍 But do it only if/when you have enough free time. :) |
Hello!
Nice work :-)
My suggestions:
The text was updated successfully, but these errors were encountered: