Allow message payload to be NULL. #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, this is a good fix! |
NULL message payloads are used with compaction topics introduced in 0.8.1 which use the NULL payload to indicate the corresponding key should be deleted. The Kafka protocol guide also notes that the Value (payload) may be NULL. https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-Messagesets This commit makes these changes: - prevents NULL payloads from being copied when RD_KAFKA_MSG_F_COPY is set. - prevents payload bytes being copied into rkbuf when NULL. - sets rkm_len to -1 when payload is NULL (just like key). - Allows NULL payloads to be received in a fetch.
secretmike
force-pushed
the
null_payloads
branch
from
56fd17f to
248ca27
Compare
edenhill
added a commit
that referenced
this pull request
Mar 20, 2015
|
Null message support is now in master. |
|
Thank you! |
|
Can you verify this works as intended for you? |
|
I'll be trying it out, but probably not until next week. On Fri, Mar 20, 2015 at 5:04 PM, Magnus Edenhill notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NULL message payloads are used with compaction topics introduced in 0.8.1
which use the NULL payload to indicate the corresponding key should be deleted.
(see Log Compaction for more details)
The Kafka protocol guide also notes that the Value (payload) may be NULL.
This commit makes these changes:
RD_KAFKA_MSG_F_COPYis set.rkbufwhen NULL.rkm_lento-1when payload is NULL (just like key).This is my first change to this code so I'm sure there are things missed. If you can point me in the right direction I'd be happy make any changes, or if you'd rather clean things yourself that works for me too :)
Thanks!