Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --env options to device restart, update commands #109

Open
annybs opened this issue Mar 18, 2022 · 1 comment
Open

Add --env options to device restart, update commands #109

annybs opened this issue Mar 18, 2022 · 1 comment

Comments

@annybs
Copy link
Member

annybs commented Mar 18, 2022

At the moment we can:

  • Specify envvars through edge device start -e ABC=def
  • Retain envvars through edge device update
  • Retain envvars through edge device restart (by virtue of not removing the original container)

However, in order to alter envvars we have to fully stop the device and reassign them through edge device start using docker inspect to check for (and manually copy) any existing envvars.

Ideally we should have a changeable env when interacting with the device in any way that causes it to run (or continue to run) the app afterwards, so that for instance if I needed to add a new envvar without worrying about the existing ones, I could run edge device restart -e GHI=jkl

Ergo:

  1. edge device start -e ABC=def 👉 container has ABC=def
  2. edge device restart -e GHI=jkl 👉 container has ABC=def GHI=jkl
  3. edge device update -e MNO=pqr 👉 container has ABC=def GHI=jkl MNO=pqr

Removing envvars could subsequently be done in one of two ways: edge device stop && edge device start to start over with a clean slate of envvars, or edge device restart -e ABC= to clear the value of an envvar.

@annybs
Copy link
Member Author

annybs commented Apr 1, 2022

Alternative/complementary solution: edge device configure ENV_VAR value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant