feature(query-params): Pass QueryParams through EdgeX to Device Services

[rsdmike]

This pull request is an example/POC that @lenny-intel and I put together of how #1564 could be accomplished. This is only 1/2 of the equation as the device-sdk would need to be updated to handle the query parameters. The good thing with this is that it wouldn't be a breaking change as the device-sdk would simply ignore the query parameters that are sent on.

Signed-off-by: Mike Johanson michael.johanson@intel.com

[tsconn23]

@ernestojeda I assume you're working on the ARM build?

13:31:26 standard_init_linux.go:190: exec user process caused "exec format error"
13:31:26 Makefile:171: recipe for target 'raml_verify' failed
13:31:26 make: *** [raml_verify] Error 1
13:31:26 Build step 'Execute shell' marked build as failure

[tsconn23]

I've asked @rsdmike to extend the unit tests with some positive cases where the querystring isn't empty and also to verify we're correctly guarding against malformed querystrings.

Will review again when updated. Otherwise LGTM. Functional test was successful.

[codecov-io]

Codecov Report

Merging #1571 into master will decrease coverage by 0.91%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #1571      +/-   ##
==========================================
- Coverage    29.4%   28.49%   -0.92%     
==========================================
  Files         125      124       -1     
  Lines       11000    10998       -2     
==========================================
- Hits         3235     3134     -101     
- Misses       7594     7697     +103     
+ Partials      171      167       -4

Impacted Files	Coverage Δ
internal/core/command/device.go	0% <0%> (ø)	⬆️
internal/core/command/restDevice.go	0% <0%> (ø)	⬆️
internal/core/command/get.go	100% <100%> (+15.38%)	⬆️
internal/core/metadata/rest_addressable.go	47.94% <0%> (-45.46%)	⬇️
...rnal/core/metadata/operators/addressable/delete.go

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae3ef6...b081903. Read the comment docs.

[tsconn23]

LGTM.

Note, I think the Codecov.io report is in error. The negatively affected files which are attributable to the nearly %1 drop aren't even part of this PR. I think the commit history in the feature branch has thrown off the report. If that turns out to not be the case, will revisit with @rsdmike in the morning.