-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update ZMQ for module directory structure. #2191
Conversation
Signed-off-by: Mike Johanson <michael.johanson@intel.com>
recheck |
Codecov Report
@@ Coverage Diff @@
## master #2191 +/- ##
=======================================
Coverage 38.78% 38.78%
=======================================
Files 175 175
Lines 13490 13490
=======================================
Hits 5232 5232
Misses 7979 7979
Partials 279 279 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs look good to me. I found them to be helpful as I have run into problems installing ZMQ on Windows! I left a couple of comments (none of which are critical to approval). The update to the guide is helpful.
recheck |
Signed-off-by: Mike Johanson <michael.johanson@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looks good! Again thanks for the helpful docs
Updated docs for getting ZMQ up and running on Windows 10 for EdgeX development.
Closes #2190
Signed-off-by: Mike Johanson michael.johanson@intel.com