Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update ZMQ for module directory structure. #2191

Merged
merged 7 commits into from
Dec 12, 2019

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented Nov 27, 2019

Updated docs for getting ZMQ up and running on Windows 10 for EdgeX development.

Closes #2190

Signed-off-by: Mike Johanson michael.johanson@intel.com

Signed-off-by: Mike Johanson <michael.johanson@intel.com>
@rsdmike rsdmike requested a review from tsconn23 November 27, 2019 19:19
@rsdmike
Copy link
Member Author

rsdmike commented Dec 2, 2019

recheck

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #2191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2191   +/-   ##
=======================================
  Coverage   38.78%   38.78%           
=======================================
  Files         175      175           
  Lines       13490    13490           
=======================================
  Hits         5232     5232           
  Misses       7979     7979           
  Partials      279      279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1079919...175eac6. Read the comment docs.

Copy link
Contributor

@jbonafide623 jbonafide623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look good to me. I found them to be helpful as I have run into problems installing ZMQ on Windows! I left a couple of comments (none of which are critical to approval). The update to the guide is helpful.

ZMQWindows.md Outdated Show resolved Hide resolved
ZMQWindows.md Show resolved Hide resolved
ZMQWindows.md Outdated Show resolved Hide resolved
@michaelestrin
Copy link
Member

recheck

Copy link
Contributor

@jbonafide623 jbonafide623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good! Again thanks for the helpful docs

@michaelestrin michaelestrin merged commit 32c2c55 into edgexfoundry:master Dec 12, 2019
@rsdmike rsdmike deleted the ZMQUpdateNov branch December 12, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ZMQ Windows Documentation
4 participants