Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added setting the Reading ID in the Events collection. #2575

Merged
merged 1 commit into from
May 29, 2020

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented May 28, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit subject follows the Conventional Commits spec
  • The commit message follows the EdgeX Contributor Guide
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • make test has completed successfully

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Reading IDs not set when Event is pushed onto the Message Bus

Issue Number: #2569

What is the new behavior?

Reading IDs available when Event is pushed onto the Message Bus

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any specific instructions or things that should be known prior to reviewing?

Other information

This makes the ID available when Event is pushed onto the Message Bus

closes edgexfoundry#2569

Signed-off-by: lenny <leonard.goodell@intel.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #2575 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2575      +/-   ##
==========================================
+ Coverage   38.69%   38.81%   +0.11%     
==========================================
  Files         145      145              
  Lines       12789    12722      -67     
==========================================
- Hits         4949     4938      -11     
+ Misses       7561     7510      -51     
+ Partials      279      274       -5     
Impacted Files Coverage Δ
internal/security/secretstore/init.go 3.92% <0.00%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb28b3...09de699. Read the comment docs.

Copy link
Contributor

@AnthonyMBonafide AnthonyMBonafide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnthonyMBonafide AnthonyMBonafide merged commit fed02ba into edgexfoundry:master May 29, 2020
@lenny-goodell lenny-goodell deleted the ReadingId branch January 14, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants