feat(security): Add waitFor subcommand for security-bootstrapper #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New subcommand waitFor is added and it replaces the functionality of dockerize Add waitForInfo for the toml configuration Building of dockerize in Dockerfile is removed Fixes: edgexfoundry#3100 Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
jim-wang-intel
added
enhancement
jim-wang-intel
requested review from
beaufrusetta,
hutchic,
jpwhitemn,
bnevis-i and
lenny-goodell
lenny-goodell
requested changes
Jan 29, 2021
Address Lenny's PR feedback. Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dockerizeTimeoutandRetryInterval)dockerizein Dockerfile is removedFixes: #3100
Signed-off-by: Jim Wang yutsung.jim.wang@intel.com
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Currently we are using
dockerize3rd party lib to do the waiting for other services.Issue Number: #3100
What is the new behavior?
Replacing the
dockerizewith internal implementedwaitForas part ofsecurity-bootstrappersubcommand.Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information
After this merged, need to update the
developer-scriptcompose files to include newly added env var. overrides used inwaitFor.Update PR created: edgexfoundry/developer-scripts#399