refactor: Rework Proxy Setup to use KongRoute struct for configuration #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes edgexfoundry#3220 BREAKING CHANGE: Names for Route configuration has changed Signed-off-by: lenny <leonard.goodell@intel.com>
bnevis-i
previously approved these changes
Mar 5, 2021
Signed-off-by: lenny <leonard.goodell@intel.com>
jim-wang-intel
requested changes
Mar 5, 2021
jim-wang-intel
approved these changes
Mar 5, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Proxy Setup uses repurposed ClientInfo struct for the Route configuration which has become an issue once the standards keys changed to service keys. This is because the key name is also used for the route name
Issue Number: #3220
What is the new behavior?
Now Proxy Setup uses existing KongRoute struct that has extra name property for the route name. The Route configuration is properly named
Routes, no longerClientsDoes this PR introduce a breaking change?
BREAKING CHANGE: Names for Route configuration has changed
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information