Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): Remove created field from Event and Reading #3299

Merged
merged 2 commits into from
Mar 29, 2021
Merged

feat(data): Remove created field from Event and Reading #3299

merged 2 commits into from
Mar 29, 2021

Conversation

weichou1229
Copy link
Member

Close #3270

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #3270

What is the new behavior?

In March-18-2021 Core WG meeting, we decided to remove created field from Event and Reading

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

In March-18-2021 Core WG meeting, we decided to remove created field from Event and Reading

Close #3270

Signed-off-by: weichou <weichou1229@gmail.com>
@weichou1229
Copy link
Member Author

This PR should hold until edgexfoundry/go-mod-core-contracts#564 merge.

@cloudxxx8
Copy link
Member

@jpwhitemn please help provide the suggestion of writing the accurate description in Swagger about origin in this PR

Close #3270

Signed-off-by: weichou <weichou1229@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 0412168 into edgexfoundry:master Mar 29, 2021
@weichou1229 weichou1229 deleted the issue-3270 branch July 15, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V2] Remove created field from Event and Reading
3 participants