Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor controller error handling #3400

Merged
merged 2 commits into from
Apr 27, 2021
Merged

refactor: Refactor controller error handling #3400

merged 2 commits into from
Apr 27, 2021

Conversation

weichou1229
Copy link
Member

Close: #3399

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #3399

What is the new behavior?

Refactor the duplicated code snippets of the controller error handling.

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@weichou1229 weichou1229 marked this pull request as draft April 26, 2021 09:08
Refactor the duplicated code snippets of the controller error handling.

Close: #3399
Signed-off-by: weichou <weichou1229@gmail.com>
@weichou1229 weichou1229 marked this pull request as ready for review April 27, 2021 06:43
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #3400 (9608611) into master (15b4cda) will decrease coverage by 2.01%.
The diff coverage is 79.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3400      +/-   ##
==========================================
- Coverage   42.57%   40.56%   -2.02%     
==========================================
  Files         189      189              
  Lines       16546    15791     -755     
==========================================
- Hits         7045     6405     -640     
+ Misses       9052     8964      -88     
+ Partials      449      422      -27     
Impacted Files Coverage Δ
internal/core/data/v2/controller/http/reading.go 78.04% <61.90%> (+3.76%) ⬆️
internal/core/data/v2/controller/http/event.go 83.78% <70.49%> (+3.78%) ⬆️
...t/notifications/v2/controller/http/notification.go 84.96% <75.51%> (+0.20%) ⬆️
...t/notifications/v2/controller/http/subscription.go 90.90% <76.08%> (+2.83%) ⬆️
...re/metadata/v2/controller/http/provisionwatcher.go 93.02% <82.35%> (+3.33%) ⬆️
...nternal/core/metadata/v2/controller/http/device.go 93.87% <83.78%> (+3.17%) ⬆️
.../core/metadata/v2/controller/http/deviceprofile.go 88.82% <84.90%> (+0.31%) ⬆️
...l/support/scheduler/v2/controller/http/interval.go 96.42% <86.36%> (+0.71%) ⬆️
...ort/scheduler/v2/controller/http/intervalaction.go 96.42% <86.36%> (+0.80%) ⬆️
.../core/metadata/v2/controller/http/deviceservice.go 96.90% <88.88%> (+2.58%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b4cda...9608611. Read the comment docs.

@lenny-goodell lenny-goodell merged commit d6c94b2 into edgexfoundry:master Apr 27, 2021
@weichou1229 weichou1229 deleted the issue-3399 branch April 28, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V2] Refactor controller error handling
3 participants