Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove obsolete V1 code, swagger & scripts #3492

Merged
merged 3 commits into from
Jun 3, 2021

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented May 20, 2021

Keeping in Draft until SysMgmt V2 implementation is complete.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

V1 code, swagger and obsolete scripts still exist.

Issue Number: #3338 & #3337

What is the new behavior?

V1 code, swagger and obsolete scripts no longer exist.

Note that SysMgmt needs further clean-up once V2 implementation is complete.

Does this PR introduce a breaking change?

  • Yes
  • No

BREAKING CHANGE: V1 API has been removed

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@lenny-goodell lenny-goodell marked this pull request as draft May 20, 2021 16:11
This was linked to issues May 20, 2021
@cloudxxx8
Copy link
Member

@cherrycl please help open a PR to remove the openapi/v1 automatic push to SwaggerHub

@cloudxxx8
Copy link
Member

we should be able to remove all the errors packages

@lenny-goodell
Copy link
Member Author

@cloudxxx8 , errors packages removed. :-)

closes edgexfoundry#3338 & edgexfoundry#3337

Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell
Copy link
Member Author

lenny-goodell commented May 28, 2021

@cloudxxx8 , the Sys Mgmt code is unclear what V1 code is need by V2 and what could be removed. All other services look clean.
We could address remaining Sys Mgmt is a separate PR.
We also need to address /internal/pkg/db which is used by V2 code in separate PR so it is moved into the V2 code.
The finally a PR to move V2 code up one level so we can drop the v2 folders. Maybe hold off on that until we do the same for core contracts.

@lenny-goodell lenny-goodell marked this pull request as ready for review May 28, 2021 23:07
@cloudxxx8
Copy link
Member

@lenny-intel no problem, and I open another issue for SMA #3526
we can merge this one first

internal/support/scheduler/schedule.go Outdated Show resolved Hide resolved
internal/support/scheduler/schedulecontext.go Outdated Show resolved Hide resolved
internal/core/command/init.go Outdated Show resolved Hide resolved
Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell requested a review from weichou1229 June 1, 2021 20:07
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weichou1229
Copy link
Member

recheck

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2021

Codecov Report

Merging #3492 (ed29f88) into master (2fbe278) will increase coverage by 7.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3492      +/-   ##
==========================================
+ Coverage   40.41%   47.85%   +7.43%     
==========================================
  Files         206      120      -86     
  Lines       16913     8219    -8694     
==========================================
- Hits         6835     3933    -2902     
+ Misses       9594     3908    -5686     
+ Partials      484      378     -106     
Impacted Files Coverage Δ
internal/security/fileprovider/main.go 0.00% <ø> (ø)
internal/security/proxy/main.go 0.00% <ø> (ø)
internal/security/secretstore/main.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbe278...ed29f88. Read the comment docs.

Copy link
Member

@weichou1229 weichou1229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lenny-goodell lenny-goodell merged commit f99dd52 into edgexfoundry:master Jun 3, 2021
@lenny-goodell lenny-goodell deleted the v1-removal branch June 3, 2021 15:55
Makefile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove V1 DB Client Remove V1 REST endpoints
6 participants