-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove obsolete V1 code, swagger & scripts #3492
Conversation
@cherrycl please help open a PR to remove the openapi/v1 automatic push to SwaggerHub |
we should be able to remove all the |
@cloudxxx8 , errors packages removed. :-) |
closes edgexfoundry#3338 & edgexfoundry#3337 Signed-off-by: lenny <leonard.goodell@intel.com>
@cloudxxx8 , the Sys Mgmt code is unclear what V1 code is need by V2 and what could be removed. All other services look clean. |
@lenny-intel no problem, and I open another issue for SMA #3526 |
Signed-off-by: lenny <leonard.goodell@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
recheck |
Codecov Report
@@ Coverage Diff @@
## master #3492 +/- ##
==========================================
+ Coverage 40.41% 47.85% +7.43%
==========================================
Files 206 120 -86
Lines 16913 8219 -8694
==========================================
- Hits 6835 3933 -2902
+ Misses 9594 3908 -5686
+ Partials 484 378 -106
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Keeping in Draft until SysMgmt V2 implementation is complete.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
V1 code, swagger and obsolete scripts still exist.
Issue Number: #3338 & #3337
What is the new behavior?
V1 code, swagger and obsolete scripts no longer exist.
Note that SysMgmt needs further clean-up once V2 implementation is complete.
Does this PR introduce a breaking change?
BREAKING CHANGE: V1 API has been removed
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information