-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(snap): update edgexfoundry snap base to core20 #3848
build(snap): update edgexfoundry snap base to core20 #3848
Conversation
This version passes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable to me for the most part, but I do wonder if it's okay for us to just delete Postgres 10 database on refresh and create a fresh version 12 database...
I have not tested the changes locally
We'll need to increment the epoch from In future, another snap would be created with epoch For more details on how the epoch works: https://snapcraft.io/docs/snap-epochs |
This commit includes a number of updates to migrate the base to core20. - postgres: updating postgres to 12.9 from 10.19. This update includes changes to the post-refresh hook to handle the three cases of a) new install, b) refresh from a postgres-10 version and c) refresh from a postgres-12 version - snapcraft-preload: updates to use latest version and fixed cmake setup - redis: make-install-var replaced with make-parameters - kong-daemon: setpriv package replaced with util-linux Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
This commit adds code in the post- and pre- refresh hooks to dump the postgres database before a refresh and then read the data back in after upgrading postres from version 10 to version 12 Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
- remove some of the passthrough statements in snapcraft.yaml - move the snapcraft-runner and snapcraft-preload logic to the postgres utility script Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
- update log messages - run kong-post-gres-setup.sh with selector argument to pick the function to run Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
- remove sql file in post_refresh Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
- resolve issue with --devmode install not working Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
- Set epoch to 6 for Kamakura. Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
- Update comments - Remove use of snapcraft-runner in command chain for connect-plug-edgex-secretstore-token Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @siggiskulason for the updates. It looks very good overall.
I've added a few suggestions inline.
- updated comments and constant names, fixed typos and other minor modifications from PR review Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thanks, @farshidtz for the review, I've pushed an update with the requested changes. Also, for testing purposes, I've pushed this snap to the
and the checkbox test for this PR can be run using this channel |
This commit includes a number of updates to migrate the base to core20.
postgres: updating postgres to 12.9 from 10.19. This update includes changes to the
post-refresh hook to handle the three cases of a) new install, b) refresh from
a postgres-10 version and c) refresh from a postgres-12 version
snapcraft-preload: updates to use latest version and fixed cmake setup
redis: make-install-var replaced with make-parameters
kong-daemon: setpriv package replaced with util-linux
Signed-off-by: Siggi Skulason siggi.skulason@canonical.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Test by building the edgexfoundry snap and running a) checkbox tests and b) TAF tests to confirm that there are no regressions.
Test the refresh by doing
1: new install
2: refresh from Ireland
Expected result: This will fail, as the epoch has been updated to 6. We will provide a later build with a 6* epoch, which will contain the pre-refresh hook code required to upgrade.
3: refresh from current build
New Dependency Instructions (If applicable)