Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(snap): upgrade to device-virtual v2.2.0-dev.7 and app-service-configurable latest/beta #3914

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Mar 18, 2022

This upgrade resolves edgexfoundry/device-virtual-go#268
Signed-off-by: Mengyi Wang mengyi.wang@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) checkbox test (device virtual) and checkbox test (rules engine) passed
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  1. Set up edgexfoundry
snap install edgexfoundry_2.2.0-dev.38_amd64.snap --devmode
snap set edgexfoundry device-virtual=on
  1. Modify ASC
sudo nano /var/snap/edgexfoundry/current/config/app-service-configurable/res/rules-engine/configuration.toml
LogLevel = "DEBUG"

  [Writable.Pipeline]
  ExecutionOrder = "FilterByDeviceName, Transform, SetResponseData"

  [Writable.Pipeline.Functions]
    [Writable.Pipeline.Functions.FilterByDeviceName]
      [Writable.Pipeline.Functions.FilterByDeviceName.Parameters]
      DeviceNames = "Random-Boolean-Device"
      FilterOut = "true"
    [Writable.Pipeline.Functions.Transform]
      [Writable.Pipeline.Functions.Transform.Parameters]
      Type = "json"
  1. Set up kuiper and app-service-configurable
snap set edgexfoundry kuiper=on
sudo edgexfoundry.kuiper-cli create stream edgexAll '()WITH(FORMAT="JSON",TYPE="edgex")'
sudo edgexfoundry.kuiper-cli create rule rule1 '
{
   "sql":"SELECT * from edgexAll",
   "actions":[
      {
         "mqtt":{
            "server":"tcp://127.0.0.1:1883",
            "topic":"sinkResult"
         }
      }
   ]
}'
  1. Check ASC function:
mosquitto_sub -t sinkResult

Expect: Random-Boolean-Device's readings have been filtered out

New Dependency Instructions (If applicable)

This upgrade resolves edgexfoundry/device-virtual-go#268
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
snap/snapcraft.yaml Outdated Show resolved Hide resolved
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #3914 (4492c6e) into main (6c3478e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3914   +/-   ##
=======================================
  Coverage   46.11%   46.11%           
=======================================
  Files         111      111           
  Lines        9591     9591           
=======================================
  Hits         4423     4423           
  Misses       4781     4781           
  Partials      387      387           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3478e...4492c6e. Read the comment docs.

@MonicaisHer MonicaisHer requested a review from farshidtz March 18, 2022 14:10
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
In future, we need to split these into separate snaps to simplify upgrades.

@farshidtz farshidtz changed the title build(snap): upgrade device-virtual and app-service-configurable build(snap): upgrade to device-virtual v2.2.0-dev.7 and app-service-configurable latest/beta Mar 18, 2022
@farshidtz farshidtz merged commit 7794663 into edgexfoundry:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

device-virtual failed device validation and doesn't produce readings since edgex-go tag v2.2.0-dev.35
3 participants