Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update instructions to get latest linter #4067

Merged
merged 1 commit into from
Jul 2, 2022
Merged

chore: Update instructions to get latest linter #4067

merged 1 commit into from
Jul 2, 2022

Conversation

bnevis-i
Copy link
Collaborator

Signed-off-by: Bryon Nevis bryon.nevis@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) n/a
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Remove golangci-lint and run make lint

New Dependency Instructions (If applicable)

@bnevis-i bnevis-i requested a review from lenny-goodell June 30, 2022 22:46
lenny-goodell
lenny-goodell previously approved these changes Jun 30, 2022
@bnevis-i
Copy link
Collaborator Author

bnevis-i commented Jul 1, 2022

Recheck

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.0% 6.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4067 (5f6e10f) into main (a157344) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4067   +/-   ##
=======================================
  Coverage   47.27%   47.27%           
=======================================
  Files         114      114           
  Lines        9850     9850           
=======================================
  Hits         4657     4657           
  Misses       4805     4805           
  Partials      388      388           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a157344...5f6e10f. Read the comment docs.

@bnevis-i bnevis-i requested a review from lenny-goodell July 2, 2022 17:47
@bnevis-i bnevis-i merged commit 33a3e4f into edgexfoundry:main Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants