Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Latest go-mods, config and Dockerfile fix #4217

Merged

Conversation

lenny-goodell
Copy link
Member

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
cmd/core-data/Dockerfile Outdated Show resolved Hide resolved
cmd/core-command/Dockerfile Outdated Show resolved Hide resolved
cmd/core-metadata/Dockerfile Outdated Show resolved Hide resolved
cmd/support-notifications/Dockerfile Outdated Show resolved Hide resolved
cmd/support-scheduler/Dockerfile Outdated Show resolved Hide resolved
ernestojeda
ernestojeda previously approved these changes Oct 25, 2022
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4217 (7bf2850) into main (9ee2498) will increase coverage by 0.01%.
The diff coverage is 52.38%.

❗ Current head 7bf2850 differs from pull request most recent head aa1fa3a. Consider uploading reports for the commit aa1fa3a to get more accurate results

@@            Coverage Diff             @@
##             main    #4217      +/-   ##
==========================================
+ Coverage   43.28%   43.29%   +0.01%     
==========================================
  Files         125      125              
  Lines       11106    11126      +20     
==========================================
+ Hits         4807     4817      +10     
- Misses       5887     5896       +9     
- Partials      412      413       +1     
Impacted Files Coverage Δ
...rnal/core/command/controller/messaging/internal.go 0.00% <0.00%> (ø)
...nternal/core/command/controller/messaging/utils.go 66.03% <75.00%> (+1.59%) ⬆️
...rnal/core/command/controller/messaging/external.go 87.23% <100.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lenny-goodell lenny-goodell merged commit 8ec1737 into edgexfoundry:main Oct 25, 2022
@lenny-goodell lenny-goodell deleted the go-mods-config-dockerfiles branch December 12, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants