Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(snap): Remove helper scripts from staged snaps #4232

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented Nov 14, 2022

The 2.3 (latest/stable) App Service Configurable and eKuiper parts add files that have duplicate names with those in the edgexfoundry snap. Moreover, there are some files that are staged but never used. This PR unstages those files.

Duplicate files prevent the snap build.

Signed-off-by: Farshid Tavakolizadeh farshid.tavakolizadeh@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@farshidtz farshidtz marked this pull request as draft November 14, 2022 17:15
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

@farshidtz
Copy link
Member Author

I reverted the eKuiper unstaging because that is not enough to fix this issue. It involves other changes to work including the refactoring of staged files (to keep eKuiper snap's helper-go at a different location) and the addition of the logic removed from the eKuiper snap's install hook. We'll stick with the 1/stable which tracks eKuiper v1.5.1 right now. The bundled kuiper app is deprecated and not worth the change at this point.

Deployment should use the standalone edgex-ekuiper from the latest/stable channel.

@farshidtz farshidtz marked this pull request as ready for review November 15, 2022 19:47
Copy link
Contributor

@MonicaisHer MonicaisHer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farshidtz Thank you, looks good!

@farshidtz farshidtz merged commit af696e2 into edgexfoundry:main Nov 16, 2022
@farshidtz farshidtz deleted the snap-unstage-helpers branch November 16, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants