Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snap)!: Remove deprecated kuiper and ASC apps from edgexfoundry snap #4250

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Dec 9, 2022

This PR removes two deprecated apps kuiper and ASC from edgexfoundry snap since version 3.0. They are available as standalone snaps: edgex-app-service-configurable snap and edegx-ekuiper snap.

Signed-off-by: Mengyi Wang mengyi.wang@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) feat!: Remove deprecated kuiper and ASC from edgexfoundry snap edgex-docs#915

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MonicaisHer MonicaisHer changed the title build(snap): Remove deprecated kuiper and ASC from edgexfoundry snap build(snap): Remove deprecated kuiper and ASC apps from edgexfoundry snap Dec 9, 2022
@MonicaisHer MonicaisHer requested a review from farshidtz December 9, 2022 13:17
@MonicaisHer MonicaisHer marked this pull request as ready for review December 9, 2022 13:18
@farshidtz farshidtz changed the title build(snap): Remove deprecated kuiper and ASC apps from edgexfoundry snap feat!(snap): Remove deprecated kuiper and ASC apps from edgexfoundry snap Dec 13, 2022
@farshidtz farshidtz changed the title feat!(snap): Remove deprecated kuiper and ASC apps from edgexfoundry snap feat(snap)!: Remove deprecated kuiper and ASC apps from edgexfoundry snap Dec 13, 2022
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, this is a breaking change and needs to have the appropriate message in the commit. I will add it to the squash message.

@farshidtz farshidtz merged commit 2918878 into edgexfoundry:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants