Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): Restore ADD_PROXY_ROUTE functionality for docker NGINX #4412

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix(security): Restore ADD_PROXY_ROUTE functionality for docker NGINX #4412

merged 1 commit into from
Mar 7, 2023

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Mar 6, 2023

This functionality was dropped in the Kong to NGINX change, and is being restored in order to make it easy to permanently add a custom route that survives "make clean" operations in Docker.

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A already documented as POR

Testing Instructions

As per existing documentation, use ADD_PROXY_ROUTE on proxy-setup to add custom routes.
Verify changes to /etc/nginx/conf.d/custom-routes.inc and /etc/nginx/templates/custom-routes.inc.template

New Dependency Instructions (If applicable)

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bnevis-i bnevis-i requested a review from jim-wang-intel March 6, 2023 23:08
@bnevis-i bnevis-i added bug Something isn't working security-services labels Mar 6, 2023
@bnevis-i bnevis-i added this to the Minnesota milestone Mar 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4412 (00e1079) into main (b9da6ae) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4412   +/-   ##
=======================================
  Coverage   41.76%   41.76%           
=======================================
  Files         106      106           
  Lines        9740     9740           
=======================================
  Hits         4068     4068           
  Misses       5325     5325           
  Partials      347      347           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnevis-i bnevis-i merged commit 3ead8ec into edgexfoundry:main Mar 7, 2023
@bnevis-i bnevis-i deleted the restore-add-proxy-route branch March 7, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security-services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants