Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to make *obvious* which platforms do not support certificate validation #70

Open
atomontage opened this issue Feb 10, 2016 · 6 comments · May be fixed by #80
Open

Comments

@atomontage
Copy link

Since it's pretty much all of them besides allegro and mocl.

@hanshuebner
Copy link
Member

Can you open a pull request with the suggested change?

@atomontage
Copy link
Author

I would if it was straightforward (just an html change) but it seems I need to get clixdoc (which isn't quicklisp installable) figure out how to use that and change the xsl. I might work on the missing certificate validation though, at least for SBCL/CCL, since I need it. I'll try and do it with drakma first, and if it turns out to be too much trouble I'll look for something else.

@tdrhq
Copy link

tdrhq commented Nov 24, 2016

I am so confused.. this sounds like a huge security issue. I just discovered this by accident since I was writing code that was intentionally hitting a self-signed server and it didn't validate.

@tdrhq
Copy link

tdrhq commented Nov 24, 2016

Oh, looks like I need to set this up in cl+ssl. It's definitely an unsafe default, but I guess I can understand why this is so.

For the record, I had to do this:
(setf (cl+ssl:ssl-check-verify-p) t)
(cl+ssl:ssl-set-global-default-verify-paths)

@libre-man
Copy link

Wouldn't it make more sense to enable ssl verification on all platforms that support it? And when enabling ssl verification, as @tdrhq stated, cl+ssl:ssl-check-verify-p is not set to T so some verification checks are not done even when ssl verification is required.

@hanshuebner
Copy link
Member

Both a code and/or a documentation change are acceptable, and I can take care of turning the change in the XML documentation into docstrings and HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants