Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths in nbexchange plugin #24

Closed
lzach opened this issue Jul 24, 2020 · 0 comments · Fixed by #112
Closed

Paths in nbexchange plugin #24

lzach opened this issue Jul 24, 2020 · 0 comments · Fixed by #112

Comments

@lzach
Copy link
Contributor

lzach commented Jul 24, 2020

Nbexchange inherits some of the path handling from nbgrader, including some of the issues.

One solution to fix this is to replace the current way having every class constructing the paths themselves with dedicated methods that do all the path handling in one place.

Another improvement is to replace the use of regex and globs to list paths (as it breaks easily when needing to regex-escape input), with functions that walk the specified path, picking up all the user and assignment details as it goes along.

This is closely related to the #14 issue, and a branch exist that tries to implement these ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant