Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

feature request: config switch between legacy and RLS mode #194

Closed
seanjensengrey opened this issue Apr 23, 2017 · 6 comments
Closed

feature request: config switch between legacy and RLS mode #194

seanjensengrey opened this issue Apr 23, 2017 · 6 comments

Comments

@seanjensengrey
Copy link

seanjensengrey commented Apr 23, 2017

Version of VSCode: 1.11.2 (1.11.2)
Version of the extension: 0.3.11
OS: OSX 10.10.5

There should be a configuration option to switch between legacy (racer, rustfmt, rustsym) and RLS mode.

If one of the legacy mode utilities is found, legacy mode is activated even if RLS is configured in settings.json via

{
    "rust.rls": {
        "executable": "rustup",
        "args": ["run", "nightly", "rls"]
    }
}

At the very least, if RLS is defined in user settings it should override the automatic detection of legacy mode.

@KalitaAlexey
Copy link
Member

@seanjensengrey,
Actually if RLS is found, it will use RLS.

@buster
Copy link

buster commented Apr 26, 2017

How do i know if RLS mode is used? It says "Racer: on" in the bottom, but rls is definitely installed.

@KalitaAlexey
Copy link
Member

@buster,
What version do you use: from the marketplace or from the source?
If you use the version from the marketplace, you should set rust.rls.executable in order to make it work.
If you use the version from the source, you shouldn't set anything, it must work.

@TedDriggs
Copy link

Is there a way to disable RLS mode on 0.3.13? I'm working on projects that use workspaces, and those aren't working well with RLS right now (see rust-lang/rls#263)

@KalitaAlexey
Copy link
Member

Remove RLS component from rustup. There is no other way.

@KalitaAlexey
Copy link
Member

@TedDriggs,
I will add "rust.forceLegacyMode: boolean" to allow this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants