forked from microsoft/vscode-editorconfig
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space indent size is not working in VSCode version 1.74 #344
Comments
The absence of indentSize in the TextEditorOptions type is discussed in this issue. |
This seems to be fixed in 1.74.1 now. |
I concur. I reproduced the linked issues with VSCode 1.74.0 and 1.74.1 versions. The issue is present in 1.74.0 but is fixed in 1.74.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is already a duplicate issue, but the title and description did not express the essence of the issue, so a new issue was created.
*
) wildcard #343Also, the content of this issue was written based on this comment.
Task
code --disable-extensions
and the issue did NOT present itself.Issue
1.74.0
0.16.4
Root
.editorconfig
Fileeditor.insertSpaces
true
____
____
editor.tabSize
4
_
_
editor.trimAutoWhitespace
true
____
____
files.autoSave
"off"
"___"
"___"
files.insertFinalNewline
false
_____
_____
files.trimTrailingWhitespace
false
_____
_____
Expected behavior
Actual behavior
Reason
vscode has been updated to separate
tabSize
andindentSize
in 1.74,but editorconfig-vscode applies the
indent_size
option in.editorconfig
only to vscode'stabSize
,and
indentSize
is This seems to be due to the fact that it has not been changed.In the actual code, only the tabSize is generated here,
editorconfig-vscode/src/api.ts
Lines 160 to 172 in b86ebd4
and the vscode setting is changed here.
editorconfig-vscode/src/api.ts
Line 54 in b86ebd4
Also, I added the
indentSize
property in the debugger on this line and run it, and it was set as expected.However, there is no
indentSize
in the TextEditorOptions type to actually change the code.The text was updated successfully, but these errors were encountered: