Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection checkboxes not behaving correctly #774

Open
lifeiscontent opened this issue Sep 16, 2024 · 7 comments
Open

collection checkboxes not behaving correctly #774

lifeiscontent opened this issue Sep 16, 2024 · 7 comments

Comments

@lifeiscontent
Copy link
Contributor

Describe the bug and the expected behavior

I'm not sure how to reproduce this but between versions 1.1.5 and 1.2.1 I'm seeing situations where if I have a defaultValue of more than 1 items selected, and have several other options, conform only seems to render 1 item as checked in the form.

Conform version

v1.2.1

Steps to Reproduce the Bug or Issue

here's a video of the reproduction:

https://www.loom.com/share/be05ee2475cd40c6b4555469869aef34

What browsers are you seeing the problem on?

Chrome, Firefox, Microsoft Edge, Safari

Screenshots or Videos

No response

Additional context

No response

@tacomanator
Copy link

Same issue for me on 1.2.1. Was working as of 1.1.5.

Double checked that the fields.foo.initialValue has the expected values, but the corresponding checkboxes are not checked in the page. I noticed that they are checked for a brief moment when the page loads, but become unchecked shortly thereafter.

@edmundhung
Copy link
Owner

I can't watch the loom video without an account. Any chance you can share a simple repo? 😅 I will take a look later today to see if I can figure something out. Sorry for the trouble.

@lifeiscontent
Copy link
Contributor Author

@edmundhung I think it might be because you're outside of the US, do you mind using a VPN? I can't reproduce it, otherwise I would have. I spent about 30 minutes trying to scope it down.

@edmundhung
Copy link
Owner

Looks like loom is complaining only when I have Cloudflare Warp on 🤔 Anyway, I figure out the issue. I will put up a PR with a pre-release for you to test it out.

@edmundhung
Copy link
Owner

edmundhung commented Sep 17, 2024

I have put up a fix on #775. Can you give the pre-release a try and let me know if you run into any issues? Thanks.

@lasseklovstad
Copy link

I had the same issue and I tested the pre-relase and it worked for me 😄

@edmundhung
Copy link
Owner

I'm sorry for the trouble. I've concluded that it's best to revert the relevant changes, and I've just published v1.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants