-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling client cache should be optionable #51
Comments
I agree - was trying to figure out what was disabling the cache (thought I mis-configured the server) and traced it back to |
Totally agree -- could we at least can turn it on/off so the cache is allowed? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The commit 713f918 added a decorator that sets the cache-control and expires headers to explicitly disable caching on the client.
While I can see how this may be useful in some cases, it doesn't work for my use case. I want to be able to allow a client which had an authorized user access an image, to keep accessing it for a short while after, thus I'd like to customize the cache-control's max-age and expires values to something else (perhaps something closer to what the S3 token expiry is set to).
How do you feel about allowing the header values to be customized? Or perhaps allowing users to specify the expiry time delta (in seconds?) or None (to disable cache) ? If you agree with one of these solutions, I would love to submit a pull request.
The text was updated successfully, but these errors were encountered: