-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input boolean arguments might be being ignored/git submodules #20
Comments
Hi @SomeoneSerge, I ran into this too - did you find a workaround? |
Hello @charlesbaynham, I actually don't remember when have I last run into this problem (or the need to use flake inputs with submodules). Lately, I've been using the new I haven't tested your PR yet, but I presume it would fix the issue |
Flake inputs since recently support boolean arguments, including
submodules = true
for git inputs, which are supposed to trigger recursive checkout.It seems, however, that
flake-compat
ignores those arguments:Flake: https://github.com/SomeoneSerge/triton.nix/blob/f1ed98b8ebad142c10032243e3a50c94dc90ffb5/flake.nix#L9
nix build -L
succeeds to check out microsoft/onnxruntime` recursively (paths in https://github.com/microsoft/onnxruntime/tree/master/cmake/external are available in sources)./build-compat.nix
fails withRelated:
The text was updated successfully, but these errors were encountered: