Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: cover image is splitted into two pages #1861

Open
seaspeak opened this issue Nov 4, 2022 · 5 comments
Open

Bug: cover image is splitted into two pages #1861

seaspeak opened this issue Nov 4, 2022 · 5 comments

Comments

@seaspeak
Copy link

seaspeak commented Nov 4, 2022

Version: Thorium.Setup.2.1.1-alpha.0.3347001418.exe

See the attched image. Changing to the smaller font size corrects the issue.

cover-splitted-into-two-pages (Small)

@danielweck
Copy link
Member

Thank you for reporting this. Would you mind privately sharing the EPUB with me? I need to check the computed style cascade in the web browser engine. Readium CSS link:
https://github.com/readium/readium-css/blob/583011453612e6f695056ab6c086a2c4f4cac9c0/css/dist/ReadiumCSS-before.css#L614-L635

@seaspeak
Copy link
Author

seaspeak commented Nov 4, 2022

I would love to. But how to share it with you privately? Do you get the email at the end of edrlab.org?

@danielweck
Copy link
Member

you can reach me at:

daniel.weck@gmail.com

@danielweck
Copy link
Member

Thank you for sharing the EPUB. Interestingly, the problem is now different due to a breaking change in the Chromium web browser engine (introduced in the latest version of Electron which Thorium 2.2 is going to ship with): instead of the image spanning across into the next CSS column, the rendering engine scrolls the page vertically!

Screenshot 2022-11-26 at 17 56 35

Related commit: readium/r2-navigator-js@b7f11fb

@danielweck
Copy link
Member

Moving issue to ReadiumCS readium/readium-css#144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants