Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mui textfield disappearing #95

Merged
merged 13 commits into from
Nov 22, 2024

Conversation

patrickjmeurer
Copy link
Contributor

Temporary fix for #90 !

:)

@patrickjmeurer patrickjmeurer changed the title Fix: Mui textfield disappearing fix: Mui textfield disappearing Nov 8, 2024
@patrickjmeurer patrickjmeurer marked this pull request as draft November 8, 2024 02:45
@patrickjmeurer patrickjmeurer marked this pull request as ready for review November 8, 2024 02:45
@eduardoborges
Copy link
Owner

Hey @patrickjmeurer! Can you update package lock file?

And can you provide some evidences? screenshots or videos of your fix.

@patrickjmeurer
Copy link
Contributor Author

Hello @eduardoborges. As you requested, in annex the video of the solution, with the packages already updated!

Gravacao.de.Tela.2024-11-08.as.22.45.09.mov

@patrickjmeurer
Copy link
Contributor Author

idk why the CI is failing, maybe cache?

@patrickjmeurer
Copy link
Contributor Author

@eduardoborges can I help with anything else on this PR?

@eduardoborges
Copy link
Owner

@eduardoborges can I help with anything else on this PR?

This version of inputmask doesnt exists

package.json Outdated
@@ -36,7 +36,7 @@
"react-dom": ">=16.4 || 17 || 18 || 20"
},
"devDependencies": {
"inputmask": "5.0.10-beta.9",
"inputmask": "5.0.10-beta.11",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eduardoborges I’ve updated the package to the latest beta version.

@patrickjmeurer
Copy link
Contributor Author

@eduardoborges some news?

@eduardoborges eduardoborges changed the title fix: Mui textfield disappearing fix: mui textfield disappearing Nov 20, 2024
@eduardoborges
Copy link
Owner

@patrickjmeurer Can you solve the conflicts?

@patrickjmeurer
Copy link
Contributor Author

@eduardoborges done! :)

@eduardoborges eduardoborges merged commit fa0caf6 into eduardoborges:main Nov 22, 2024
5 checks passed
eduardoborges pushed a commit that referenced this pull request Nov 22, 2024
## [3.4.2](3.4.1...3.4.2) (2024-11-22)

### Bug Fixes

* mui textfield disappearing ([#95](#95)) ([fa0caf6](fa0caf6))
@eduardoborges
Copy link
Owner

🎉 This PR is included in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants